self-serve-code-review

Reviews LFX One pull request diffs against documented Angular and Express standards.

12|6|Updated Jul 14, 2025
One-click install
npx skills add https://github.com/linuxfoundation/lfx-self-serve --skill self-serve-code-review-linuxfoundation
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: self-serve-code-review
Source: https://github.com/linuxfoundation/lfx-self-serve/tree/main/.github/skills/self-serve-code-review
Command: npx skills add https://github.com/linuxfoundation/lfx-self-serve --skill self-serve-code-review-linuxfoundation

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Reviewing pull requests in the LFX One monorepo requires judging each diff against the repo's own documented conventions for the Angular SSR frontend and Express BFF backend, which is hard to do consistently from a diff alone. ## Core Features & Use Cases - Standards-based review: Holds every diff to the repo's documented rules in CLAUDE.md, .claude/rules/, and the docs/reviews/ checklists, citing the documented source in each finding. - Line-level quality judgment: Evaluates correctness, error handling, tests, performance, readability, and code truthfulness on the changed code, scaled to the size of the change. - Repo-specific checks: Flags shared-package boundary violations, raw PrimeNG usage where LFX wrappers exist, SSR-unsafe browser API usage, critical constant changes, and protected-file edits. - Use Case: When reviewing a PR that adds a new Express controller and Angular component, use this Skill to verify the controller passes errors via next(error), the component reads signals instead of calling methods in templates, and new shared types live in @lfx-one/shared. ## Quick Start Review this pull request diff against the repo's documented standards and report any findings with file and line references.

Frequently Asked Questions about self-serve-code-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a pull request against repo-specific coding standards?▼

Read the repo's documented standards first (CLAUDE.md, .claude/rules/, docs/reviews/ checklists), then judge each diff hunk against them in its full context. Cite the documented source in any standards finding rather than relying on generic best practices.

How to review Angular SSR code for browser-only API usage?▼

Check that window, document, localStorage, navigator, and observers sit behind an isPlatformBrowser guard or a non-SSR render callback. Browser-only libraries must be lazy-imported inside that boundary, since a static top-level import crashes the SSR bundle under yarn build.

What should a code review check in an Express controller and service pattern?▼

Verify controllers pass errors to the handler via next(error), services throw custom error classes like BaseApiError, and nothing is silently swallowed or leaked to the client. Also confirm user bearer tokens versus M2M tokens are used correctly and upstream API contracts are validated.

When is a changed constant a code review finding?▼

A changed timeout, retry value, page-size cap, cache TTL, rate-limit tier, feature-flag default, env-var key, or upstream URL is a behavior change. The finding is an unaccounted blast radius, not the absence of an explanation for a correct new value.

Does this review approach cover security issues in pull requests?▼

No, security review is handled by a separate skill (self-serve-security-review). This skill covers line-level quality dimensions only, though it notes when a server-only secret crossing the SSR boundary belongs to the security review.