Converts array membership checks into Set and Map lookups in TypeScript code.
npx skills add https://github.com/lxsmnsyc/overwander --skill prefer-sets-lxsmnsyc
Please help me install this Agent Skill. Skill: prefer-sets Source: https://github.com/lxsmnsyc/overwander/tree/main/.agents/skills/prefer-sets Command: npx skills add https://github.com/lxsmnsyc/overwander --skill prefer-sets-lxsmnsyc
.includes(), .indexOf(), or .some() on arrays, which performs an O(n) scan on every query and obscures intent. This Skill enforces a consistent rule: any "is X one of these values" check uses a Set (or Map when a value is attached) for O(1) hash lookups. ## Core Features & Use Cases - Static lookup tables: Declares constant collections as const FOO = new Set<T>([...]) at module scope and queries them with .has() instead of ARRAY.includes(x). - Dynamic membership tracking: Uses Set.add/delete for mutable collections like units on a field or seen ids, replacing array.push plus indexOf/splice removal patterns. - Disguised membership detection: Flags predicate scans that reduce to identity comparison (arr.some(v => v === x)) and converts them to Set lookups. - Use Case: While reviewing a battle engine, you find MAJOR_STATUS_CONDITIONS.some((s) => s === status); the Skill rewrites it as a module-level MAJOR_STATUS Set queried with .has(status). ## Quick Start Review this TypeScript file and convert every array membership check into a Set or Map lookup, keeping arrays only where order or genuine predicate filtering matters.High-intent search queries and answers about installing and using this skill.
Declare the collection as `const FOO = new Set<T>([...])` at module scope and query it with `FOO.has(x)` instead of `FOO.includes(x)`. This changes membership checks from an O(n) scan to an O(1) hash lookup.
Use a Set whenever code answers "is this value in this collection", especially for collections queried more than once or larger than a couple of entries. Predicate scans like `arr.some(v => v === x)` are membership checks in disguise and should also become Sets.
Keep an array when order matters, such as priority lists or iteration sequences, when the collection is only ever iterated, or when the callback does real filtering work like `arr.some(v => v.alive && v.team === t)`. Tuples and JSON-shaped data also stay as arrays.
Keep a Set, or a Map when a value is attached, and mutate it with `add` and `delete`. Never use `array.push` combined with `indexOf` and `splice` for removal, which is slower and error-prone.
Keep the existing array export so other modules can still iterate it, but add a Set counterpart for membership checks. Callers that only test membership should query the Set rather than scanning the array.
jakildevProfile hot-path code with IR_PROFILE macros and easy_profiler to identify CPU- and GPU-bound hotspots.
vstorm-coRefactor codebases incrementally while running tests after each change.
CDO-07-NewEstablish coding conventions for naming, readability, immutability, and error handling.
Harmeet10000Provides type-safe generic Map, Filter, Reduce, and GroupBy utilities for Go slices and maps.