logic-error

Check what happens when totalSupply equals zero and whether assets can be donated directly to the vault without minting shares. Look for virtual share offsets or minimum deposit requirements, and verify the initial share ratio cannot be manipulated by an attacker depositing 1 wei then donating tokens.

Solidity truncates integer division, so computing a / b * c loses precision when a is smaller than b, often yielding zero. Reordering to a * c / b preserves precision when overflow is not a risk, and any X / Y * Z pattern should be flagged during audit.

No. Solidity 0.8 adds automatic overflow checks, but unchecked blocks and inline assembly bypass this protection entirely. Auditors should grep for unchecked and assembly blocks and verify that inputs cannot cause wraparound in those sections.

Search for swap, exchange, or trade functions and verify they accept a minimum output parameter such as amountOutMin or minAmountOut. A swap that transfers whatever amount the calculation returns lets attackers sandwich the transaction for profit.

Rounding errors accumulate across repeated calls and can be exploited at scale, as in the Bunni attack which caused $2.4M-$8.3M in losses. The rule is to round against the user: round down on withdrawals so users receive less, and round down on deposits so users pay more.

Test zero, one, maximum uint256, first user, last user, and boundary values just above or below limits. These cases expose division by zero, rounding to zero, overflow in unchecked blocks, ratio manipulation on empty state, and off-by-one errors.