fx-review

Applies a shared triage, materiality, and convergence procedure to code reviews across reviewer tools.

Updated Nov 2, 2025
One-click install
npx skills add https://github.com/fx/skills --skill fx-review-fx
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: fx-review
Source: https://github.com/fx/skills/tree/main/skills/fx-review
Command: npx skills add https://github.com/fx/skills --skill fx-review-fx

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code review loops stall when reviewers report out-of-scope findings, fix one instance of a repeated pattern, or act on low-value nitpicks, producing endless review cycles. This Skill defines one canonical review procedure — Scope Brief, triage, materiality, convergence, and reporting — that every reviewer adapter in the catalog follows, so reviews terminate instead of drifting. ## Core Features & Use Cases - Scope Brief enforcement: Requires every review to carry a Scope Brief so deliberately excluded work is never reported as missing, while security, privacy, and correctness defects always stay in scope. - Ordered triage and dispositions: Applies scope, contract, and materiality filters in order, then assigns exactly one disposition — blocking, immaterial, or deferred — with defined actions for each. - Class-level fixing and convergence: Fixes findings as swept classes proven by search, re-runs until no blocking finding remains unresolved, and reports per-pass trends and tier counts. - Use Case: When reviewing a branch with Codex, Copilot, or CodeRabbit, load this procedure first so the adapter skill only handles tool invocation while triage, convergence, and reporting stay consistent across all reviewers. ## Quick Start Review the current branch changes using the fx-review procedure with the Scope Brief from the active workflow.

Frequently Asked Questions about fx-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I run a code review that converges instead of looping forever?▼

Carry a Scope Brief into every pass, triage findings through scope, contract, and materiality filters in order, and fix blocking findings as whole classes rather than single instances. Repeat until no blocking finding remains unresolved, which is the only convergence test.

What is a Scope Brief in code review?▼

A Scope Brief states what the change was asked to do, so reviewers do not report deliberately excluded work as missing. It never suppresses real findings: security, privacy, data-loss, and correctness defects inside the change are always in scope.

Does this review procedure work with Copilot and CodeRabbit?▼

Yes, the procedure is shared across reviewer adapters including Codex, Copilot, and CodeRabbit. The adapter skills handle tool invocation and output parsing, while triage, dispositions, and convergence rules come from this procedure.

When should a review finding be marked immaterial?▼

A finding is immaterial when it passes the scope and contract filters but falls below the materiality bar, such as wording or counts nothing acts on. Immaterial findings get a reply with reasoning and are resolved with no edit to the artifact.

Why record incorrect reviewer findings in REVIEW.md?▼

Recording a misread convention in REVIEW.md stops Codex, Copilot, and CodeRabbit from raising the same false positive again, since all of them read that file. The entry is required work, not an edit made for an immaterial finding.