Question 1

How do I review Java Spring Boot code for security issues?

Accepted Answer

Check for SQL injection by verifying all queries use parameterized bindings instead of string concatenation, confirm endpoints have @PreAuthorize authorization, escape user input to prevent XSS, and ensure passwords and tokens are never written to logs.

Question 2

How to detect and fix N+1 query problems in JPA?

Accepted Answer

N+1 occurs when iterating entities triggers a lazy-load query per item. Fix it with a JOIN FETCH query or an @EntityGraph specifying the associations to load eagerly, and add pagination instead of loading full tables into memory.

Question 3

Why should Lombok @Data and @Setter be avoided on JPA entities?

Accepted Answer

@Data generates setters, equals, and toString that break entity encapsulation and can cause lazy-loading or equality bugs. Use @Getter with @Builder and expose state changes through domain methods like activate() or updatePrice() that enforce business rules.

Question 4

What code quality metrics should a Java project enforce?

Accepted Answer

Common thresholds are at least 80% line coverage from JaCoCo, cyclomatic complexity of 10 or less per method, methods under 20 lines, classes under 200 lines, and duplicated code below 3% as measured by SonarQube.

Question 5

When should @Transactional be placed on service methods?

Accepted Answer

Place @Transactional on service-layer methods that group multiple database operations, never on controllers. Use readOnly = true for query-only methods, avoid calling external APIs inside a transaction, and add @Version for optimistic locking on concurrent updates.

Code Review & Source Analysis

SYSTEM DOCUMENTATION & REQUIREMENTS

Frequently Asked Questions about Code Review & Source Analysis

Related Skills

be

gsd-review-fix

java-coverage

sonar