code-review

Review GMT Temporal code for error handling, Date-object bans, and test coverage patterns.

6|Updated Mar 10, 2026
One-click install
npx skills add https://github.com/northguild/gmt --skill code-review-northguild
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: code-review
Source: https://github.com/northguild/gmt/tree/main/.agents/skills/code-review
Command: npx skills add https://github.com/northguild/gmt --skill code-review-northguild

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Reviewing code in GMT Temporal projects requires checking Temporal-specific rules that generic review checklists miss, such as banning Date objects, wrapping Temporal parsing in try-catch, and avoiding plain/zoned type mixing. ## Core Features & Use Cases - Canonical Checklist Enforcement: Defers to a single source-of-truth checklist covering API contracts, architecture, tests, documentation, and reviewer tone. - Pattern Recognition Examples: Provides worked examples of common violations including missing try-catch around Temporal.PlainDate.from, new Date() usage, and plain/zoned mixing. - Test Convention Guidance: Flags incorrect it.each array syntax and shows the required template literal form plus pre-built error-path mocks. - Use Case: When reviewing a pull request in the gmt, gmt-oxlint, gmt-eslint, or gmt-biome packages, apply this skill to catch Temporal error-handling gaps and test convention violations before merge. ## Quick Start Review this pull request in the gmt package using the GMT Temporal code review checklist and flag any Date object usage or missing error handling.

Frequently Asked Questions about code-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review code in a Temporal-first JavaScript date library?▼

Apply the canonical code review checklist covering API contract, architecture, tests, and documentation. Specifically check that Temporal parsing is wrapped in try-catch, no Date objects are used, and plain and zoned types are never mixed.

What patterns should reviewers flag in GMT Temporal projects?▼

Flag missing try-catch around Temporal.PlainDate.from, any new Date() usage, mixing of PlainDate and ZonedDateTime logic, and array-syntax it.each tests. The skill provides worked examples of each violation alongside corrected versions.

Which packages does this code review skill cover?▼

It covers the four GMT packages: gmt, gmt-oxlint, gmt-eslint, and gmt-biome. All of them follow the same Temporal-first, string-only I/O conventions enforced by the shared checklist.

How should error paths be tested in GMT Temporal code?▼

Use pre-built mocks imported via relative paths from the test/mocks directory, such as mockTemporalPlainDateFromThrow. Tests should verify that functions return an empty string when Temporal parsing throws, since there is no @gmt/test alias.

Why does the skill not include the full review checklist inline?▼

The canonical checklist lives in a separate context file that serves as the single source of truth. Duplicating it inside the skill would risk the two copies drifting out of sync, so the skill only supplements it with worked violation examples.