code-review-methodology

What problem does it solve?

This Skill provides a repeatable, stage-gated methodology to evaluate code changes so reviewers can verify acceptance criteria first and then prioritize security, correctness, performance, maintainability, tests, and conventions without wasting effort on broken logic.

Core Features & Use Cases

• Two-stage review: enforce spec compliance (Stage 1) before performing quality assessments (Stage 2).
• Five-facet evaluation: run parallel checks for security, quality/correctness, conventions, tests, and requirements mapping.
• Finding synthesis: deduplicate by file:line, prioritize P1→P2→P3, group findings by file, and report counts with confidence levels.
• Process rules: confidence guidelines, noise filters, boy-scout recognition for small cleanups, review-cycle awareness, and adversarial agent-team protocols for disputed findings.
• Use case: Triage a pull request by mapping each acceptance criterion to implementation evidence, surface P1 security/correctness issues that block merges, and produce a concise, prioritized finding report.

Quick Start

Review the pull request for unmet acceptance criteria, verify Stage 1 compliance, then run a five-facet review prioritizing security and correctness and output deduplicated P1/P2/P3 findings with confidence assessments.