code-review

Reviews code diffs against Basic Machines house style and architecture rules.

4.0k|282|Updated Dec 2, 2024
One-click install
npx skills add https://github.com/basicmachines-co/basic-memory --skill code-review-basicmachines-co
Or copy as Structured Prompt for Agent▼
Please help me install this Agent Skill.
Skill: code-review
Source: https://github.com/basicmachines-co/basic-memory/tree/main/.agents/skills/code-review
Command: npx skills add https://github.com/basicmachines-co/basic-memory --skill code-review-basicmachines-co

SYSTEM DOCUMENTATION & REQUIREMENTS

What problem does it solve? Code reviews in the basic-memory and basic-memory-cloud repositories require consistent judgment about house style, architecture boundaries, and pre-merge risk, which generic review passes often miss. ## Core Features & Use Cases - Rubric-Based Review: Evaluates diffs for cognitive load, change propagation, knowledge duplication, accidental complexity, dependency direction, domain model distortion, and test oracle quality. - House Rule Enforcement: Explicitly checks for speculative getattr defaults, broad exception swallowing, hidden casts, dataclass/Pydantic misuse, and unclear async resource ownership. - Severity-Ranked Reporting: Outputs findings ordered by severity (high, medium, low) with file:line references, concrete evidence, and minimal fix suggestions. - Use Case: Before merging a pull request in basic-memory-cloud, run this skill to verify tenant/workspace isolation boundaries are respected and that risky changes include meaningful regression tests. ## Quick Start Ask the AI to review the current diff or named files using the code-review skill and report findings by severity.

Frequently Asked Questions about code-review

High-intent search queries and answers about installing and using this skill.

FAQPage Schema
How do I review a pull request against repo-specific style rules?▼

Point the skill at the current diff or named files and it checks them against the repo's AGENTS.md, CLAUDE.md, and ENGINEERING_STYLE.md guidance. Findings are reported by severity with file:line references and suggested fixes.

What architecture risks does this code review check for?▼

It checks dependency direction across API/MCP/CLI, services, repositories, and UI stores, plus cognitive load, change propagation, knowledge duplication, accidental complexity, and domain model distortion. In basic-memory-cloud it also prioritizes tenant and workspace isolation.

Does the code review skill edit my code automatically?▼

No, it reports findings only and does not edit code unless you explicitly ask it to fix specific findings. Each finding includes the smallest practical fix suggestion or notes when product input is needed.

What severity levels does the review report use?▼

Findings use three levels: high for correctness, security, data-loss, or tenant isolation failures; medium for maintainability or boundary risks; low for minor consistency issues. If there are no findings, it says so and notes remaining verification gaps.

When should I not use this review skill?▼

It is scoped to Basic Machines repositories and their house conventions, so it is not suited for general-purpose review of unrelated codebases. It also does not replace running tests or linters, since it only reviews diffs and named files.